fix: make Docker Compose and Docker Run sections self-contained - #256
Closed
manato-tajiri wants to merge 1 commit into
Closed
fix: make Docker Compose and Docker Run sections self-contained#256manato-tajiri wants to merge 1 commit into
manato-tajiri wants to merge 1 commit into
Conversation
- Add mkdir, curl/Invoke-WebRequest commands inline in both Docker sections - Add PowerShell code blocks for Windows users - Each section is now a complete copy-paste solution - Fixes the issue where config.yaml was created as a directory by Docker when users jumped directly to the Docker Compose section without completing prerequisite setup steps
Owner
|
Hi @manato-tajiri, thanks for the PR and the write-up! This should already be covered: the current And as @pejotigrek noted, this is really just Docker's standard bind-mount behavior, not something specific to NoteDiscovery. Going to close this out, but thanks again! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker Compose and Docker Run sections in the README were not self-contained. Users jumping directly to these sections would run without existing, causing Docker to create it as a directory (Docker's behavior when binding a non-existent file path to a container).
Fix
Each Docker section now includes all prerequisite commands inline:
Each section is now a complete copy-paste solution that works without referencing other sections.
Fixes the issue where was created as a directory by Docker when users jumped directly to the Docker Compose section without completing prerequisite setup steps.